Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-544: Shared Sentry transactions convenient API #705

Merged
merged 3 commits into from
Oct 11, 2023
Merged

ALTAPPS-544: Shared Sentry transactions convenient API #705

merged 3 commits into from
Oct 11, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Oct 11, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
ALTAPPS-544

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Implement SentryInteractor.withTransaction extension to automatically start and finish a transaction

@XanderZhu XanderZhu added the shared Shared module task label Oct 11, 2023
@XanderZhu XanderZhu added this to the 1.37 milestone Oct 11, 2023
@XanderZhu XanderZhu self-assigned this Oct 11, 2023
@XanderZhu
Copy link
Contributor Author

@ivan-magda @vladkash
I've updated ProjectSelectionListActionDispatcher.handleFetchContentAction, HomeActionDispatcher.fetchHomeScreenData and ProgressScreenActionDispatcher.handleFetchTrackWithProgressAction to show the new API in the action.
Please, provide your feedback: how do you like it.

@ivan-magda ivan-magda changed the title [Shared] Sentry transactions convenient api ALTAPPS-544: Shared Sentry transactions convenient api Oct 11, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-544: Shared Sentry transactions convenient api ALTAPPS-544: Shared Sentry transactions convenient API Oct 11, 2023
ivan-magda
ivan-magda approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, provide your feedback: how do you like it.

Looks nice 👍

shared/src/commonMain/kotlin/org/hyperskill/app/home/presentation/HomeActionDispatcher.kt Outdated Show resolved Hide resolved
@ivan-magda ivan-magda marked this pull request as ready for review October 11, 2023 12:42
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Oct 11, 2023
@vladkash
Copy link
Contributor

Looks good to me 👍

@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Oct 11, 2023
@XanderZhu XanderZhu merged commit efc85aa into develop Oct 11, 2023
9 checks passed
@XanderZhu XanderZhu deleted the feature/ALTAPPS-544/Shared-Discovering-of-simplifying-Sentry-Performance-Tracking-API branch October 11, 2023 15:35
@XanderZhu XanderZhu removed the ready to pull Pull Request is ready to merge label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

@vladkash vladkash vladkash approved these changes

Assignees

@XanderZhu XanderZhu

Labels
shared Shared module task
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@XanderZhu @vladkash @ivan-magda