Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-997: iOS first problem onboarding #702

Merged
merged 22 commits into from
Oct 11, 2023
Merged

ALTAPPS-997: iOS first problem onboarding #702

merged 22 commits into from
Oct 11, 2023

Conversation

vladkash
Copy link
Contributor

@vladkash vladkash commented Oct 10, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-997

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Implemented first problem onboarding screen
  • Supported navigation view actions from shared module
  • Navigation to study plan will be implemented in ALTAPPS-1004

@vladkash
add feature with reducer for draft pull request
c0fe003
@vladkash
fixes/comments
06e10eb
@vladkash
add analytic
d87d102
@vladkash
add action dispatcher, injection and view state
82d89cd
@vladkash
implement navigation
01a370d
@vladkash
add strings and updating profile after track selection
48cdeae
@vladkash
review fixes
ef19617
@vladkash
template for first problem onboarding screen
b5a7399
@vladkash
fix shared module interface for passing complete onboarding result
deac426
@vladkash
Merge branch 'feature/ALTAPPS-996/shared_first_problem_onboarding' in…
52a4747 
…to feature/ALTAPPS-997/iOS_first_problem_onboarding
@vladkash
add first problem onboarding content view
1a354bf
@vladkash
shared review fixes
a08c3d8
@vladkash
remove unused iOS code
d643397
@vladkash
Merge branch 'feature/ALTAPPS-996/shared_first_problem_onboarding' in…
fd98b2d 
…to feature/ALTAPPS-997/iOS_first_problem_onboarding
@vladkash
implement first problem onboarding screen content and new navigation
efd6132
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Oct 10, 2023
@vladkash vladkash changed the base branch from develop to feature/first_problem_onboarding October 10, 2023 09:30
@vladkash
Merge remote-tracking branch 'origin/feature/first_problem_onboarding…
cfd269a 
…' into feature/ALTAPPS-997/iOS_first_problem_onboarding

# Conflicts:
#	iosHyperskillApp/iosHyperskillApp/Sources/Modules/App/AppViewModel.swift
#	iosHyperskillApp/iosHyperskillApp/Sources/Modules/App/ViewControllers/AppViewController.swift
#	iosHyperskillApp/iosHyperskillApp/Sources/Modules/TrackSelection/Details/TrackSelectionDetailsViewModel.swift
#	iosHyperskillApp/iosHyperskillApp/Sources/Modules/TrackSelection/Details/Views/TrackSelectionDetailsView.swift
#	shared/src/commonMain/resources/MR/base/strings.xml
@github-actions github-actions bot removed the android Android module task label Oct 10, 2023
@vladkash vladkash added this to the 1.37 milestone Oct 11, 2023
@vladkash vladkash added the awaiting review Pull Request is awaiting code reviews label Oct 11, 2023
@vladkash vladkash marked this pull request as ready for review October 11, 2023 06:53
ivan-magda
ivan-magda reviewed Oct 11, 2023
View reviewed changes
...sHyperskillApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingView.swift Outdated Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Outdated Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Outdated Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Outdated Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Outdated Show resolved Hide resolved
...killApp/Sources/Modules/FirstProblemOnboarding/Views/FirstProblemOnboardingContentView.swift Outdated Show resolved Hide resolved
...osHyperskillApp/Sources/Modules/FirstProblemOnboarding/FirstProblemOnboardingViewModel.swift Show resolved Hide resolved
...osHyperskillApp/Sources/Modules/FirstProblemOnboarding/FirstProblemOnboardingViewModel.swift Outdated Show resolved Hide resolved
@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Oct 11, 2023
@vladkash vladkash added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Oct 11, 2023
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Oct 11, 2023
@ivan-magda ivan-magda merged commit 1e44ea9 into feature/first_problem_onboarding Oct 11, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-997/iOS_first_problem_onboarding branch October 11, 2023 18:27
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@vladkash vladkash

Labels
ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
2 participants
@vladkash @ivan-magda