Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1006: iOS integrate AppsFlyer #700

Merged
merged 13 commits into from
Oct 16, 2023
Merged

ALTAPPS-1006: iOS integrate AppsFlyer #700

merged 13 commits into from
Oct 16, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Oct 9, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-1006

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Intergarates AppsFlyer SDK into iOS app
  2. Adds AnalyticEngine interface to provide platform-specific analytic engines into shared analytic code
  3. Logs AppsFlyer events

@ivan-magda ivan-magda added this to the 1.37 milestone Oct 9, 2023
@github-actions github-actions bot added shared Shared module task ios iOS module task labels Oct 9, 2023
@github-actions github-actions bot added the android Android module task label Oct 10, 2023
@ivan-magda ivan-magda marked this pull request as ready for review October 10, 2023 12:43
@ivan-magda ivan-magda changed the title ALTAPPS-1006: iOS intergate AppsFlyer ALTAPPS-1006: iOS integrate AppsFlyer Oct 10, 2023
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Oct 11, 2023
@ivan-magda

This comment was marked as outdated.

Sign in to view
XanderZhu
XanderZhu reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@XanderZhu XanderZhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
As I mentioned in detailed comments, we can make AnalyticsInteractor clear of the engine's details, and work with them uniformly.

...ed/src/commonMain/kotlin/org/hyperskill/app/analytic/domain/interactor/AnalyticInteractor.kt Outdated Show resolved Hide resolved
...ed/src/commonMain/kotlin/org/hyperskill/app/analytic/domain/interactor/AnalyticInteractor.kt Outdated Show resolved Hide resolved
@XanderZhu XanderZhu added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Oct 13, 2023
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Oct 16, 2023
@ivan-magda ivan-magda merged commit 98f7f96 into develop Oct 16, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1006/setup_apps_flyer branch October 16, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XanderZhu XanderZhu XanderZhu approved these changes

Assignees

@ivan-magda ivan-magda

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-magda @XanderZhu