Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-950: Android make code editor an active input #692

Merged

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Oct 4, 2023

YouTrack Issues:
ALTAPPS-950

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Extract keyboard extension logic from CodeStepQuizFullScreenDialogFragment to reuse it in CodeStepQuizFragment;
  • Make codeEditor active input in CodeStepQuizFragment;
  • Update code quiz UI;
  • Replace SqlStepQuizFragment with CodeStepQuizFragment.

@XanderZhu XanderZhu self-assigned this Oct 4, 2023
@XanderZhu XanderZhu added the android Android module task label Oct 4, 2023
@github-actions github-actions bot added the shared Shared module task label Oct 4, 2023
@XanderZhu XanderZhu changed the title Feature/altapps 950/android make code editor active ALTAPPS-950: Android make code editor active Oct 4, 2023
@XanderZhu XanderZhu marked this pull request as ready for review October 4, 2023 12:15
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Oct 4, 2023
@XanderZhu XanderZhu added this to the 1.36 milestone Oct 4, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-950: Android make code editor active ALTAPPS-950: Android make code editor an active input Oct 4, 2023
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a problem is in a terminal state (successful submission or wrong, ...) user should not have the ability to navigate to the full-screen code editor, otherwise it can modify reply and submit it.

No bottom padding

optional (tiny suggestion)

Keyboard input accessory buttons overlap the cursor. You can reproduce this by tapping the "new line" button multiple times.

@XanderZhu
Copy link
Contributor Author

XanderZhu commented Oct 5, 2023

@ivan-magda
It wouldn't be fast to implement auto scroll so that Keyboard input accessory buttons are not overlapping codeEditor.
It's possible now for users to scroll manually. We can implement this feature later.

@ivan-magda ivan-magda merged commit 6a7a011 into develop Oct 6, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-950/Android-make-code-editor-active branch October 6, 2023 06:19
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants