ALTAPPS-890: Fix Android daily reminder #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-890
Checklist
Before Code Review:
Description
The root cause of this bug are race-conditions. The
ProfileFragmentsend messages which should save the availability flag or reminder time in the settings, but these operations are asynchronous. So,DailyStudyReminderLocalNotificationDelegateaccess the data before they are updated via actionDispatcher.I've removed the
notificationInteractoraccess fromDailyStudyReminderLocalNotificationDelegatein case of notification planning from theProfileFragment.