Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-745: Android add problems limit to study plan #465

Merged
merged 3 commits into from
May 3, 2023
Merged

ALTAPPS-745: Android add problems limit to study plan #465

merged 3 commits into from
May 3, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented May 3, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
#ALTAPPS-745

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Add ProblemsLimit widget into StudyPlan screen;
  • Hide ProblemsLimit root container if its state is Empty;
  • Fix StudyPlan last item offset.

@XanderZhu XanderZhu added bug Something isn't working android Android module task labels May 3, 2023
@XanderZhu XanderZhu added this to the 1.16 milestone May 3, 2023
@XanderZhu XanderZhu self-assigned this May 3, 2023
@XanderZhu XanderZhu requested a review from ivan-magda May 3, 2023 15:10
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label May 3, 2023
@ivan-magda ivan-magda marked this pull request as ready for review May 3, 2023 15:13
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label May 3, 2023
@ivan-magda ivan-magda merged commit d2b9d12 into develop May 3, 2023
@ivan-magda ivan-magda deleted the feature/ALTAPPS-745/Add-problems-limit-to-study-plan branch May 3, 2023 15:21
@ivan-magda ivan-magda mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task bug Something isn't working
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda