Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-664: shared activities pagination inside section #457

Conversation

vladkash
Copy link
Contributor

@vladkash vladkash commented Apr 27, 2023

YouTrack Issues:
#ALTAPPS-664

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Added pagination for root topics section
  • Changed detection for section next activity
  • Fixed tests and add new ones

…ination_inside_section

# Conflicts:
#	shared/src/commonMain/kotlin/org/hyperskill/app/learning_activities/domain/model/LearningActivity.kt
#	shared/src/commonMain/kotlin/org/hyperskill/app/study_plan/widget/presentation/StudyPlanWidgetActionDispatcher.kt
#	shared/src/commonMain/kotlin/org/hyperskill/app/study_plan/widget/presentation/StudyPlanWidgetFeature.kt
@vladkash vladkash added the awaiting review Pull Request is awaiting code reviews label Apr 27, 2023
@vladkash vladkash added this to the 1.16 milestone Apr 27, 2023
@vladkash vladkash self-assigned this Apr 27, 2023
@github-actions github-actions bot added the shared Shared module task label Apr 27, 2023
@ivan-magda

This comment was marked as resolved.

@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Apr 27, 2023
@vladkash vladkash removed the request for review from ivan-magda April 27, 2023 13:50
@vladkash vladkash added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Apr 27, 2023
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Apr 29, 2023
@ivan-magda ivan-magda merged commit 539dd5c into develop Apr 29, 2023
@ivan-magda ivan-magda deleted the feature/ALTAPPS-664/shared_activities_pagination_inside_section branch April 29, 2023 14:53
@ivan-magda ivan-magda mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants