Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-535: Android add swipeRefresh to Home, Track and Profile fragments #433

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Apr 11, 2023

YouTrack Issues:
#ALTAPPS-535

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • SwipeRefreshLayout added as a root element into Home, Track & Profile fragments layouts
  • Handle SwipeRefreshLayout.isRefreshing

@XanderZhu XanderZhu added the android Android module task label Apr 11, 2023
@XanderZhu XanderZhu added this to the 1.15 milestone Apr 11, 2023
@XanderZhu XanderZhu self-assigned this Apr 11, 2023
@XanderZhu XanderZhu marked this pull request as ready for review April 11, 2023 12:45
@ivan-magda ivan-magda changed the title Android: Add swipeRefresh to Home, Track and Profile fragments ALTAPPS-535: Android add swipeRefresh to Home, Track and Profile fragments Apr 11, 2023
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Apr 11, 2023
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XanderZhu pull-to-refresh is available only for content states (when data is loaded and actual UI is displayed)?

@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Apr 11, 2023
@XanderZhu
Copy link
Contributor Author

pull-to-refresh is available only for content states (when data is loaded and actual UI is displayed)?

It is true for the profile screen when there is a single synchronous

Should I block pull-to-refresh on Home & Track for non-Content states?

@ivan-magda
Copy link
Member

ivan-magda commented Apr 11, 2023

pull-to-refresh is available only for content states (when data is loaded and actual UI is displayed)?

It is true for the profile screen when there is a single synchronous

Should I block pull-to-refresh on Home & Track for non-Content states?

Yes, it's better to do like on the Profile tab (iOS behavior), and as far as I remember reducers also does this check for Content state

@ivan-magda ivan-magda merged commit 25963ab into develop Apr 14, 2023
@ivan-magda ivan-magda deleted the feature/ALTAPPS-535/Android-Add-pull-to-refresh-on-Home-Track-and-Profile-screen branch April 14, 2023 19:50
@ivan-magda ivan-magda mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants