Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-643: Shared handle rejected submission feedback #393

Merged
merged 9 commits into from
Mar 13, 2023
Merged

ALTAPPS-643: Shared handle rejected submission feedback #393

merged 9 commits into from
Mar 13, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Mar 10, 2023 •
edited by XanderZhu
Loading

YouTrack Issues:
#ALTAPPS-643

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Adds support to Submission.feedback either as a string and as an object with title and message

@ivan-magda ivan-magda added this to the 1.11 milestone Mar 10, 2023
@github-actions github-actions bot added ios iOS module task shared Shared module task labels Mar 10, 2023
@ivan-magda
Copy link
Member Author

@XanderZhu please add the necessary changes for the Android part

Links:

  1. https://vyahhi.myjetbrains.com/youtrack/issue/ALTAPPS-643/Shared-Add-default-serialization-value-for-submission-status#focus=Comments-74-220933.0-0
  2. https://vyahhi.myjetbrains.com/youtrack/issue/ALT-8571/Update-error-limit-is-reached-in-the-API-Submissions#focus=Comments-74-220996.0-0

@github-actions github-actions bot added the android Android module task label Mar 11, 2023
@XanderZhu
Copy link
Contributor

@ivan-magda
Is it OK, thar backend send a feedback as s string at the moment?
It could not be parsed now.

@ivan-magda
Copy link
Member Author

@ivan-magda

Is it OK, thar backend send a feedback as s string at the moment?

It could not be parsed now.

Backend can serialize feedback in two formats: plain string or object. How feedback will be serialized depends on many circumstances.

For now we just handle submission rejected feedback.

@XanderZhu
Copy link
Contributor

XanderZhu commented Mar 12, 2023 •
edited
Loading

@ivan-magda
If I got you right, FeedbackRejectedSubmission could be either String or object, just the same as Feedback interface, right?

@ivan-magda
Copy link
Member Author

@ivan-magda

If I got you right, FeedbackRejectedSubmission could be either String or object, just the same as Feedback interface, right?

No, rejected submission is only an object https://vyahhi.myjetbrains.com/youtrack/issue/ALT-8571/Update-error-limit-is-reached-in-the-API-Submissions#focus=Comments-74-220996.0-0

XanderZhu and others added 3 commits March 13, 2023 13:38
@XanderZhu
Replace FeedbackRejectedSubmission with Feedback.Object
0f164af
@XanderZhu
Merge remote-tracking branch 'origin/develop' into feature/ALTAPPS_64…
5b9143d 
…3/shared_handle_rejected_submission_feedback

# Conflicts:
#	androidHyperskillApp/src/main/java/org/hyperskill/app/android/step_quiz/view/model/StepQuizFeedbackState.kt
@vladkash
fix iOS build
3a69da1
@XanderZhu XanderZhu merged commit 351f87c into develop Mar 13, 2023
@XanderZhu XanderZhu deleted the feature/ALTAPPS_643/shared_handle_rejected_submission_feedback branch March 13, 2023 11:25
@XanderZhu XanderZhu mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XanderZhu XanderZhu XanderZhu approved these changes

Assignees

@ivan-magda ivan-magda

@XanderZhu XanderZhu

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-magda @XanderZhu @vladkash