Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-609: Shared fix add study_plan filter to learning activities request #372

Merged
merged 3 commits into from
Feb 24, 2023
Merged

ALTAPPS-609: Shared fix add study_plan filter to learning activities request #372

merged 3 commits into from
Feb 24, 2023

Conversation

vladkash
Copy link
Contributor

@vladkash vladkash commented Feb 23, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
#ALTAPPS-609

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

@vladkash vladkash added the awaiting review Pull Request is awaiting code reviews label Feb 23, 2023
@vladkash vladkash added this to the 1.10 milestone Feb 23, 2023
@vladkash vladkash self-assigned this Feb 23, 2023
@github-actions github-actions bot added the shared Shared module task label Feb 23, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-609: add study plan param to learning activities request ALTAPPS-609: Shared add study plan param to learning activities request Feb 23, 2023
@XanderZhu XanderZhu added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Feb 24, 2023
@vladkash vladkash added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Feb 24, 2023
@github-actions github-actions bot added the android Android module task label Feb 24, 2023
@ivan-magda
Fix getTopicsToDiscoverNext
b38868b 
If currentStudyPlan not loaded -> then it's an error.
@ivan-magda ivan-magda merged commit 542e5d1 into develop Feb 24, 2023
@ivan-magda ivan-magda deleted the feature/ALTAPPS_609/shared_different_next_topics_in_web_and_mobile branch February 24, 2023 14:10
@ivan-magda ivan-magda added bug Something isn't working and removed awaiting review Pull Request is awaiting code reviews labels Feb 24, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-609: Shared add study plan param to learning activities request ALTAPPS-609: Shared fix add study_plan filter to learning activities request Feb 28, 2023
@ivan-magda ivan-magda mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

@XanderZhu XanderZhu Awaiting requested review from XanderZhu

Assignees

@vladkash vladkash

Labels
android Android module task bug Something isn't working shared Shared module task
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@vladkash @ivan-magda @XanderZhu