ALTAPPS-598: Shared topic completion bottom sheet continue with next topic logic #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-magda
reviewed
Feb 20, 2023
...ain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt
Outdated
Show resolved
Hide resolved
XanderZhu
reviewed
Feb 20, 2023
...c/commonMain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionFeature.kt
Outdated
Show resolved
Hide resolved
XanderZhu
reviewed
Feb 20, 2023
...ain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt
Outdated
Show resolved
Hide resolved
XanderZhu
added
awaiting changes
vladkash
added
awaiting review
XanderZhu
added
awaiting changes
…on_sheet_continue_next_topic_logic # Conflicts: # shared/src/commonMain/kotlin/org/hyperskill/app/step_completion/injection/StepCompletionComponentImpl.kt # shared/src/commonMain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt # shared/src/commonMain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionReducer.kt
vladkash
added
awaiting review
XanderZhu
reviewed
Feb 21, 2023
...ain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt
Outdated
Show resolved
Hide resolved
XanderZhu
approved these changes
Feb 21, 2023
ivan-magda
reviewed
Feb 21, 2023
...ain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt
Outdated
Show resolved
Hide resolved
ivan-magda
reviewed
Feb 21, 2023
...ain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionActionDispatcher.kt
Outdated
Show resolved
Hide resolved
ivan-magda
reviewed
Feb 21, 2023
...c/commonMain/kotlin/org/hyperskill/app/step_completion/presentation/StepCompletionReducer.kt
Show resolved
Hide resolved
ivan-magda
added
awaiting changes
…8/shared_topic_completion_sheet_continue_next_topic_logic
…_completion_sheet_continue_next_topic_logic' into feature/ALTAPPS_598/shared_topic_completion_sheet_continue_next_topic_logic
vladkash
deleted the
feature/ALTAPPS_598/shared_topic_completion_sheet_continue_next_topic_logic
branch
ivan-magda
removed
the
awaiting changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-598
Checklist
Before Code Review:
Description
Added next step id to step completion feature and message for continue with next topic button