Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-541: iOS topic progress #334

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

vladkash
Copy link
Contributor

@vladkash vladkash commented Jan 27, 2023

YouTrack Issues:
#ALTAPPS-541

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

@vladkash vladkash added the awaiting review Pull Request is awaiting code reviews label Jan 27, 2023
@vladkash vladkash added this to the 1.8 milestone Jan 27, 2023
@vladkash vladkash self-assigned this Jan 27, 2023
@github-actions github-actions bot added the ios iOS module task label Jan 27, 2023
@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Jan 30, 2023
@vladkash vladkash added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Feb 1, 2023
@ivan-magda
Copy link
Member

@vladkash I fixed the bounce animation for the TopicToDiscoverNextButtonView 915c70e. Firstly I tried to write a review message on how to fix this, but it was unclear...

Initially, I tried to extend OutlineButtonStyle so that it will support a way to provide a generic background (some View), but no way, because of Swift Generics, the compiler was unable to resolve the generic type...

Then I understand that .buttonStyle(..) applies to the Button's label and in the TopicToDiscoverNextButtonView we are applying background with the progress indicator to the Button (not to its label content), so I just moved the progress background into Button's label and now animation works correctly.

old

screencast1.mp4

new

screencast2.mp4

@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Feb 2, 2023
@vladkash vladkash merged commit 79f1793 into develop Feb 2, 2023
@vladkash vladkash deleted the feature/ALTAPPS_541/iOS_topic_progress branch February 2, 2023 17:15
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Feb 10, 2023
@ivan-magda ivan-magda mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ios iOS module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants