Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-540: Shared, Android display topics progress #323

Merged
merged 4 commits into from
Jan 18, 2023
Merged

ALTAPPS-540: Shared, Android display topics progress #323

merged 4 commits into from
Jan 18, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jan 17, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-540

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Allow progress request for all tracks
  • Add isCompleted, isSkipped, capacity fields to TopicProgress
  • Add TopicProgress.completenessPercentage extension to calculate progress
  • Implement progress ui on Android platform

@XanderZhu XanderZhu self-assigned this Jan 17, 2023
@XanderZhu XanderZhu added android Android module task awaiting review Pull Request is awaiting code reviews shared Shared module task labels Jan 17, 2023
@XanderZhu XanderZhu changed the title ALTAPPS-540 ALTAPPS-540: Shared, Android display topics progress Jan 17, 2023
ivan-magda
ivan-magda reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! But we need to wait for response (will we implement "Learn next" design)

@ivan-magda ivan-magda added this to the 1.8 milestone Jan 18, 2023
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Jan 18, 2023
@XanderZhu XanderZhu merged commit 26c07b7 into develop Jan 18, 2023
@XanderZhu XanderZhu deleted the feature/ALTAPPS-540/Shared-Android-topic-progress branch January 18, 2023 08:25
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Feb 10, 2023
@ivan-magda ivan-magda mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task shared Shared module task
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda