Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-475: Android change not completed streak icon in header #307

Merged
merged 2 commits into from
Jan 10, 2023
Merged

ALTAPPS-475: Android change not completed streak icon in header #307

merged 2 commits into from
Jan 10, 2023

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jan 9, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
#ALTAPPS-475

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Add an empty streak icon
  • Add conditions to use it ic HomeFragment

@XanderZhu XanderZhu self-assigned this Jan 9, 2023
@XanderZhu XanderZhu added android Android module task awaiting review Pull Request is awaiting code reviews labels Jan 9, 2023
@XanderZhu XanderZhu added this to the 1.7 milestone Jan 9, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-475: Android-Change-not-completed-streak-icon-in-header ALTAPPS-475: Android change not completed streak icon in header Jan 10, 2023
@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Jan 10, 2023
@XanderZhu XanderZhu added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Jan 10, 2023
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Jan 10, 2023
@XanderZhu XanderZhu merged commit 16b9435 into develop Jan 10, 2023
@XanderZhu XanderZhu deleted the feature/ALTAPPS-475/Android-Change-not-completed-streak-icon-in-header branch January 10, 2023 08:02
@ivan-magda ivan-magda mentioned this pull request Jan 16, 2023
Merged
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda