Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-420: Fix step_quiz.domain.model.submissions.Cell serialisation #290

Merged
merged 2 commits into from
Dec 29, 2022
Merged

ALTAPPS-420: Fix step_quiz.domain.model.submissions.Cell serialisation #290

merged 2 commits into from
Dec 29, 2022

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Dec 27, 2022 •
edited
Loading

YouTrack Issues:
#ALTAPPS-420

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Implement delegate to store complex objects in Fragement.arguments
  • Use new delegate to store chosenColumns fields

@XanderZhu XanderZhu added bug Something isn't working android Android module task labels Dec 27, 2022
@XanderZhu XanderZhu added this to the 1.7 milestone Dec 27, 2022
@XanderZhu XanderZhu self-assigned this Dec 27, 2022
ivan-magda
ivan-magda approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если будет время, то было бы круто написать 2 теста на это: один из них на то что должно зафейлится, когда без сериализатора, а в другом случае успех, когда с сериализатором.

@ivan-magda ivan-magda added the ready to pull Pull Request is ready to merge label Dec 29, 2022
@XanderZhu XanderZhu merged commit 25d4538 into develop Dec 29, 2022
@XanderZhu XanderZhu deleted the feature/ALTAPS-420/Android-Crash-Cell-Serialization branch December 29, 2022 06:53
@ivan-magda ivan-magda changed the title ALTAPPS-420: Fix cell serialisation ALTAPPS-420: Fix step_quiz.domain.model.submissions.Cell serialisation Dec 31, 2022
@ivan-magda ivan-magda mentioned this pull request Dec 31, 2022
Merged
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task bug Something isn't working
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda