Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1344: Shared, Android subscription annual plan #1177

Merged

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Sep 6, 2024

YouTrack Issues:
ALTAPPS-1344

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Load all the offering from RevenueCat and get the first available package from it (see PurchaseManager.getSubscriptionProducts(): Result<List<SubscriptionProduct>>);
  • Replace PurchaseManager.getFormattedMobileOnlySubscriptionPrice with PurchaseManager.getSubscriptionProducts().firstOrNull().formattedPrice;
  • Replace PurchaseManager.purchaseMobileOnlySubscription with PurchaseManager.purchaseSubscriptionProduct;
  • Use a RevenueCat pod as a dependency for iosMain module, to be able to provide StoreProduct to SubscriptionProduct;
  • Implement PurchaseManager.getSubscriptionProducts on iOS side in iosMain module;
  • The rest of the methods of the PurchaseManager is still implemented on the ios platform code (let's move it to the iosMain later);
  • Update PurchaseManager.purchase on the ios platform to work with StoreProduct;
  • Update Paywall ui on the Android platform.

@XanderZhu XanderZhu self-assigned this Sep 6, 2024
@XanderZhu XanderZhu added shared Shared module task ios iOS module task android Android module task labels Sep 6, 2024
@XanderZhu XanderZhu changed the title ALTAPPS-1344: Shared, Android subscription yearly plan ALTAPPS-1344: Shared, Android subscription annual plan Sep 9, 2024
@XanderZhu

This comment was marked as resolved.

@XanderZhu XanderZhu marked this pull request as ready for review September 9, 2024 09:41
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Sep 9, 2024
@ivan-magda ivan-magda added this to the 1.71 milestone Sep 9, 2024
@ivan-magda ivan-magda merged commit c246ab8 into develop Sep 10, 2024
16 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1344/Shared-Android-subscription-yearly-plan branch September 10, 2024 04:51
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants