-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALTAPPS-1344: Shared, Android subscription annual plan #1177
Merged
ivan-magda
merged 12 commits into
develop
from
feature/ALTAPPS-1344/Shared-Android-subscription-yearly-plan
Sep 10, 2024
Merged
ALTAPPS-1344: Shared, Android subscription annual plan #1177
ivan-magda
merged 12 commits into
develop
from
feature/ALTAPPS-1344/Shared-Android-subscription-yearly-plan
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mProductIdentifiers.MOBILE_ONLY_MONTHLY_SUBSCRIPTION
…ractor.getSubscriptionProducts
…oduct in the HyperskillStoreProduct
...c/androidMain/kotlin/org/hyperskill/app/purchases/domain/model/SubscriptionOption.android.kt
Fixed
Show fixed
Hide fixed
androidHyperskillApp/src/main/java/org/hyperskill/app/android/paywall/ui/PaywallContent.kt
Fixed
Show fixed
Hide fixed
androidHyperskillApp/src/main/java/org/hyperskill/app/android/paywall/ui/PaywallContent.kt
Fixed
Show fixed
Hide fixed
androidHyperskillApp/src/main/java/org/hyperskill/app/android/paywall/ui/SubscriptionProduct.kt
Fixed
Show fixed
Hide fixed
...c/androidMain/kotlin/org/hyperskill/app/purchases/domain/model/SubscriptionOption.android.kt
Fixed
Show fixed
Hide fixed
shared/src/iosMain/kotlin/org/hyperskill/app/purchases/domain/manager/IosPurchaseManagerImpl.kt
Fixed
Show fixed
Hide fixed
shared/src/iosMain/kotlin/org/hyperskill/app/purchases/domain/model/SubscriptionOption.ios.kt
Fixed
Show fixed
Hide fixed
XanderZhu
added
shared
Shared module task
ios
iOS module task
android
Android module task
labels
Sep 6, 2024
XanderZhu
changed the title
ALTAPPS-1344: Shared, Android subscription yearly plan
ALTAPPS-1344: Shared, Android subscription annual plan
Sep 9, 2024
…droid-subscription-yearly-plan
This comment was marked as resolved.
This comment was marked as resolved.
ivan-magda
approved these changes
Sep 10, 2024
ivan-magda
deleted the
feature/ALTAPPS-1344/Shared-Android-subscription-yearly-plan
branch
September 10, 2024 04:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
ALTAPPS-1344
Checklist
Before Code Review:
Description
PurchaseManager.getSubscriptionProducts(): Result<List<SubscriptionProduct>>
);PurchaseManager.getFormattedMobileOnlySubscriptionPrice
withPurchaseManager.getSubscriptionProducts().firstOrNull().formattedPrice
;PurchaseManager.purchaseMobileOnlySubscription
withPurchaseManager.purchaseSubscriptionProduct
;iosMain
module, to be able to provideStoreProduct
toSubscriptionProduct
;PurchaseManager.getSubscriptionProducts
on iOS side in iosMain module;PurchaseManager
is still implemented on the ios platform code (let's move it to the iosMain later);PurchaseManager.purchase
on the ios platform to work withStoreProduct
;