Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1340: Shared, iOS code blanks if statement #1175

Merged

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Sep 5, 2024

YouTrack Issues:
#ALTAPPS-1340

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Adds if statement support in shared
  • Renders if statement support on iOS

@ivan-magda ivan-magda self-assigned this Sep 5, 2024
@github-actions github-actions bot added shared Shared module task ios iOS module task labels Sep 5, 2024
@ivan-magda ivan-magda added this to the 1.71 milestone Sep 11, 2024
@ivan-magda ivan-magda marked this pull request as ready for review September 11, 2024 04:46
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Sep 11, 2024
@ivan-magda ivan-magda changed the title ALTAPPS-1340: Shared, iOS code blanks conditions ALTAPPS-1340: Shared, iOS code blanks if statement Sep 11, 2024
@XanderZhu XanderZhu added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Sep 11, 2024
@XanderZhu
Copy link
Contributor

@ivan-magda
I suggest to split these methods of the StepQuizCodeBlanksReducer, they are too much long.

  • handleDeleteButtonClicked
  • handleSpaceButtonClicked
  • handleSuggestionClicked
    Also, I suggest to not just suppressing Detekt issues like LongMethod, NestedBlockDepth & CyclomaticComplexMethod, but trying to resolve these issues.

@ivan-magda ivan-magda merged commit 4f701bd into develop Sep 12, 2024
13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1340/Shared-iOS-Code-blanks-conditions branch September 12, 2024 06:31
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants