Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix StageImplementationFragment crash #1149

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[Android] Fix StageImplementationFragment crash #1149

merged 1 commit into from
Aug 6, 2024

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Aug 6, 2024 •
edited
Loading

YouTrack Issues:
ALTAPPS-1320

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Fix StageImplementationFragment does not implement StepNavigationContainer interface which is required to successfully call requireStepRouter in StepDelegate.

@XanderZhu XanderZhu self-assigned this Aug 6, 2024
@XanderZhu XanderZhu added bug Something isn't working android Android module task awaiting review Pull Request is awaiting code reviews labels Aug 6, 2024
@XanderZhu XanderZhu marked this pull request as ready for review August 6, 2024 12:44
@ivan-magda ivan-magda added this to the 1.67 milestone Aug 6, 2024
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Aug 6, 2024
@XanderZhu XanderZhu merged commit 622350c into develop Aug 6, 2024
14 checks passed
@XanderZhu XanderZhu deleted the feature/ALTAPPS-1320/Android-Fix-StageFragment-not-attached-to-StepNavigationContainer branch August 6, 2024 13:06
@XanderZhu XanderZhu removed the ready to pull Pull Request is ready to merge label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task bug Something isn't working
Projects
None yet
Milestone
1.67
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda