ALTAPPS-1323: Shared research analytic logging issue #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neActionDispatcherConfig and not bound to analytic.
ivan-magda
approved these changes
Aug 6, 2024
...java/org/hyperskill/app/android/stage_implementation/fragment/StageImplementationFragment.kt
Outdated
Show resolved
Hide resolved
| .flushEvents(eventsToFlush, isAuthorized) | ||
| .onFailure { | ||
| mutex.withLock { | ||
| hyperskillCacheDataSource.logEvents(eventsToFlush) |
There was a problem hiding this comment.
I suppose that there is a case where the current user profile can be changed between logEvent, and old analytic events can revert to being associated with the previous user profile.
However, it is not so critical right now.
There was a problem hiding this comment.
@ivan-magda
Yes, you are right. Good point to think about.
ivan-magda
added
ready to pull
…ytic-logging-issue
ivan-magda
deleted the
feature/ALTAPPS-1323/Shared-research-analytic-logging-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
ALTAPPS-1323
Checklist
Before Code Review:
Description
AnalyticActionDispatchertoCompletableCoroutineActionDispatcherand remove analytic reference;CompletableCoroutineActionDispatcherTest;AnalyticHyperskillRepositoryTest.