Skip to content

Commit

Permalink
Merge pull request #715 from hyperskill/release/1.38
Browse files Browse the repository at this point in the history
Release 1.38
  • Loading branch information
ivan-magda authored Oct 24, 2023
2 parents a660620 + 3b0c87c commit c61a6b0
Show file tree
Hide file tree
Showing 99 changed files with 2,770 additions and 264 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/android_beta_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -44,7 +44,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/android_release_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -39,7 +39,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/automerge_into_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1
with:
fetch-depth: 0
token: ${{ secrets.GH_PAT }}
Expand Down Expand Up @@ -84,5 +84,7 @@ jobs:
git push origin release/$next_version_number
else
echo "No existing release/$next_version_number branch found"
echo "Not yet implemented"
echo "Creating new release/$next_version_number branch"
./setup_new_release_branch.sh $next_version_number
fi
4 changes: 2 additions & 2 deletions .github/workflows/build_caches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand All @@ -55,7 +55,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -64,7 +64,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand All @@ -84,7 +84,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup Ruby
uses: ruby/setup-ruby@v1.150.0
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand All @@ -144,7 +144,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand All @@ -167,7 +167,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cleanup_pr_caches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Cleanup
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Detect changes
uses: dorny/paths-filter@v2.11.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh_pages_analytics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ios_beta_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -44,7 +44,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ios_release_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -36,7 +36,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios_unit_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge_main_into_develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1
with:
fetch-depth: 0
token: ${{ secrets.GH_PAT }}
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ local.properties
*.dSYM

iosHyperskillApp/.build/

iosHyperskillApp/.idea/
iosHyperskillApp/.bundle/
iosHyperskillApp/vendor/

## moko-kswift
iosHyperskillApp/iosHyperskillApp/Sources/Frameworks/sharedSwift/Hyperskill-Mobile_shared.swift
Expand Down
1 change: 1 addition & 0 deletions androidHyperskillApp/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies {
implementation(libs.android.ui.appcompat)
implementation(libs.android.ui.constraintlayout)
implementation(libs.android.ui.swiperefreshlayout)
implementation(libs.android.ui.flexbox)
implementation(libs.android.ui.core.ktx)
implementation(libs.android.ui.fragment)
implementation(libs.android.ui.fragment.ktx)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,11 @@ class GamificationToolbarDelegate(
if (state is GamificationToolbarFeature.State.Content) {
with(viewBinding.gamificationStreakDurationTextView) {
isVisible = true
val streakDuration = state.streak?.currentStreak ?: 0
text = streakDuration.toString()
val historicalStreak = state.streak?.history?.firstOrNull()
text = state.currentStreak.toString()
setCompoundDrawablesWithIntrinsicBounds(
/* left = */ when {
historicalStreak?.state == StreakState.RECOVERED -> R.drawable.ic_menu_recovered_streak
historicalStreak?.isCompleted == true -> R.drawable.ic_menu_enabled_streak
state.historicalStreak.state == StreakState.RECOVERED -> R.drawable.ic_menu_recovered_streak
state.historicalStreak.isCompleted -> R.drawable.ic_menu_enabled_streak
else -> R.drawable.ic_menu_empty_streak
},
/* top = */ 0,
Expand All @@ -70,12 +68,12 @@ class GamificationToolbarDelegate(
text = state.hypercoinsBalance.toString()
}

state.trackWithProgress.let { trackProgress ->
state.trackProgress.let { trackProgress ->
viewBinding.gamificationTrackProgressLinearLayout.isVisible = trackProgress != null
if (trackProgress != null) {
viewBinding.gamificationTrackProgressView.setProgress(
trackProgress.averageProgress,
trackProgress.trackProgress.isCompleted
trackProgress.isCompleted
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package org.hyperskill.app.android.step_quiz.view.factory
import androidx.fragment.app.Fragment
import org.hyperskill.app.android.step_quiz_choice.view.fragment.ChoiceStepQuizFragment
import org.hyperskill.app.android.step_quiz_code.view.fragment.CodeStepQuizFragment
import org.hyperskill.app.android.step_quiz_fill_blanks.fragment.FillBlanksStepQuizFragment
import org.hyperskill.app.android.step_quiz_matching.view.fragment.MatchingStepQuizFragment
import org.hyperskill.app.android.step_quiz_parsons.view.fragment.ParsonsStepQuizFragment
import org.hyperskill.app.android.step_quiz_sorting.view.fragment.SortingStepQuizFragment
Expand Down Expand Up @@ -42,6 +43,9 @@ object StepQuizFragmentFactory {
BlockName.PARSONS ->
ParsonsStepQuizFragment.newInstance(step, stepRoute)

BlockName.FILL_BLANKS ->
FillBlanksStepQuizFragment.newInstance(step, stepRoute)

else ->
UnsupportedStepQuizFragment.newInstance()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ abstract class DefaultStepQuizFragment :
view?.snackbar(messageRes = org.hyperskill.app.R.string.connection_error)
}
is StepQuizFeature.Action.ViewAction.NavigateTo.Home -> {
requireRouter().backTo(MainScreen())
requireRouter().backTo(MainScreen(Tabs.TRAINING))
mainScreenRouter.switch(Tabs.TRAINING)
}
is StepQuizFeature.Action.ViewAction.NavigateTo.StepScreen -> {
Expand Down
Loading

0 comments on commit c61a6b0

Please sign in to comment.