Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential deadlock broadcasting to a closed WS connection #226

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

peterbroadhurst
Copy link
Contributor

Port of hyperledger/firefly-transaction-manager#28 to EthConnect codebase, which shares this WS socket management code.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #226 (a863493) into main (a2a305b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a863493 differs from pull request most recent head 33c4340. Consider uploading reports for the commit 33c4340 to get more accurate results

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   97.23%   97.20%   -0.03%     
==========================================
  Files          70       70              
  Lines        7660     7663       +3     
==========================================
+ Hits         7448     7449       +1     
- Misses        163      164       +1     
- Partials       49       50       +1     
Impacted Files Coverage Δ
ethconnect/internal/events/logprocessor.go 98.31% <0.00%> (-1.69%) ⬇️
ethconnect/internal/ws/wsserver.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vdamle vdamle merged commit 5ee45fd into hyperledger:main Aug 31, 2022
@vdamle vdamle deleted the ws-dl branch August 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants