Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAB-18529 added null check in channel header parsing #2838

Merged
merged 1 commit into from
Aug 19, 2021
Merged

FAB-18529 added null check in channel header parsing #2838

merged 1 commit into from
Aug 19, 2021

Conversation

Param-S
Copy link
Contributor

@Param-S Param-S commented Aug 18, 2021

Type of change

  • Bug fix

Description

Fuzz testing has reported SEGV while sending incomplete/null
message request to orderer. When the submit request payload
is null, the orderer fails with SEGV while trying to parse/read
the channel header.

Signed-off-by: Parameswaran Selvam parselva@in.ibm.com

@Param-S Param-S requested a review from a team as a code owner August 18, 2021 15:19
@C0rWin
Copy link
Contributor

C0rWin commented Aug 18, 2021

Seems you need to fix test

--- FAIL: TestProcessSystemChannelNormalMsg (0.00s)
    --- FAIL: TestProcessSystemChannelNormalMsg/Missing_header (0.00s)
        systemchannel_test.go:56: 
            	Error Trace:	systemchannel_test.go:56
            	Error:      	Expect "error retrieving channel header: Invalid envelope payload. can't be nil" to match "header not set"
            	Test:       	TestProcessSystemChannelNormalMsg/Missing_header

@Param-S
FAB18529 added nil check in channel header parsing
ebf94b1 
Fuzz testing has reported SEGV while sending incomplete/null
message request to orderer.

Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>
@Param-S
Copy link
Contributor Author

Param-S commented Aug 19, 2021

additional check was caused the unit test failure. It was redundant. corrected it now.

@C0rWin C0rWin merged commit 540fff8 into hyperledger:main Aug 19, 2021
@denyeart
Copy link
Contributor

@Mergifyio backport release-2.3

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify mergify bot mentioned this pull request Aug 19, 2021
Merged
@mergify
Copy link

mergify bot commented Aug 19, 2021

Command backport release-2.3: success

Backports have been created

@mergify mergify bot mentioned this pull request Aug 19, 2021
Merged
@mergify
Copy link

mergify bot commented Aug 19, 2021

Command backport release-2.2: success

Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rWin C0rWin C0rWin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Param-S @C0rWin @denyeart