Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-18264] Allow cb.Config with no ACLs to be loaded #38

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

satota2
Copy link
Contributor

@satota2 satota2 commented Oct 8, 2020

This patch allows Config Transaction Library to load cb.Config which does not contain any values for ACLs.

Type of change

  • Bug fix

Description

Currently, ConfigTx Library gives errors when reading cb.Config which does not contain values for ACLs.

Example of error:

config does not contain value for ACLs
retrieving application acls: config does not contain value for ACLs

On the other hand, In the actual Fabric channel settings, ACLs may not be set.
This is because the default value is used if it is not set.

  • e.g., fabric-samples/test-network does not set ACLs (refer to configtx.yaml).
  • ConfigTx Library seems to be able to create ConfigTX with empty ACLs.

So, this patch allows Config Transaction Library to load cb.Config which does not contain any values for ACLs.

Related issues

This patch allows Config Transaction Library to load cb.Config
which does not contain any values for ACLs.

Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
@satota2 satota2 requested a review from a team as a code owner October 8, 2020 19:45
Copy link
Contributor

@caod123 caod123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I'll cut a new release if you need this @satota2

@caod123 caod123 merged commit a053a30 into hyperledger:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants