fix(security): address CVE-2021-3749 - axios >=0.22.0 #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Oct 13, 2023
sandeepnRES
reviewed
Oct 18, 2023
There was a problem hiding this comment.
LGTM @petermetz I've approved it, but there are some conflicts, please resolve it in order to merge it.
sandeepnRES
approved these changes
Oct 18, 2023
@sandeepnRES Thank you for the review! I'm on it! |
Ensured that axios is updated to >=0.22.0 in all packages that use it. The only place where it was not possible to upgrade it through upgrading transitive dependencies was the ubiquity connector package so for that one I forced the issue through the resolutions section of the root package.json. ----------------------------------------------- The GitHub Cacti security advisory: https://github.com/hyperledger/cacti/security/dependabot/361 The general GitHub security advisory: GHSA-cph5-m8f7-6c5x Weaknesses - [WeaknessCWE-400](https://cwe.mitre.org/data/definitions/400.html) - [WeaknessCWE-1333](https://cwe.mitre.org/data/definitions/1333.html) CVE ID: `CVE-2021-3749` GHSA ID: `GHSA-cph5-m8f7-6c5x` Fixes hyperledger#2790 [skip ci] Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2790
branch
from
1eb0017
to
ea4a50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured that axios is updated to >=0.22.0 in all packages that use it.
The only place where it was not possible to upgrade it through upgrading
transitive dependencies was the ubiquity connector package so for that one
I forced the issue through the resolutions section of the root package.json.
The GitHub Cacti security advisory: https://github.com/hyperledger/cacti/security/dependabot/361
The general GitHub security advisory: GHSA-cph5-m8f7-6c5x
Weaknesses
CVE ID:
CVE-2021-3749GHSA ID:
GHSA-cph5-m8f7-6c5xFixes #2790
[skip ci]
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
[ ] Rebased onto
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.[ ] Have git sign off at the end of commit message to avoid being marked red. You can add
-sflag when usinggit commitcommand. You may refer to this link for more information.[ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.