-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove connection protocol #3184
base: main
Are you sure you want to change the base?
refactor: remove connection protocol #3184
Conversation
@dbluhm it was mentioned on the call this was moved to a plugin. Is the code to enable using that plugin included in this pr? |
It’s in the plugin repo: hyperledger/aries-acapy-plugins#925 |
@swcurran thank you, I was referring towards the "code required to make this plugin work" which was highlighted in the meeting. The functionality lost/broken features outlined here, will this require code from within the aca-py code base or it can all be managed in the external plugin? |
Doh…sorry about that. Good point. And per my comment in the meeting — is it viable to simply document how to use the plugin? I suppose not being able to use the artifacts directly (e.g., having to change the Python code) might be a bit too painful. |
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
feb4202
to
5f60057
Compare
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
With the most recent updates on this branch and to the corresponding plugin, I have successfully completed a connection using the plugged in connection protocol. There are some failing tests I will address but I will go ahead and mark this as ready for review. |
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Quality Gate failedFailed conditions |
This PR Removes the deprecated connections protocol.
In addition to the message handlers and routes, this also means:
aries_cloudagent.connections.routes
(fromaries_cloudagent.protocols.connections.v1_0.routes
).I am expecting this to not be fully functional yet so opening as a draft for now.