Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For proof problem handler, allow no connection record (OOB cases), prevent unhandled exception #3068

Merged

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Jun 25, 2024

Details in #3069

Just add a conditional to handle the case where there's no connection record. Already did this for v1.0 here #2723 but missed this was done in a different place for 2.0

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Copy link

sonarcloud bot commented Jun 25, 2024

Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Could have a unit test just for completeness if wanting to be thorough.

@jamshale jamshale merged commit e949b02 into hyperledger:main Jun 25, 2024
8 checks passed
@loneil loneil deleted the bugfix/pres20ProblemHandlerConnections branch July 29, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants