Add ConnectionProblemReport handler #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense to tackle #2599 in this PR. will be adding commits to address that issue. |
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
…stent with didexchange Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
dbluhm
force-pushed
the
issue-2530-abandoned-connection
branch
from
d27a842
to
f985372
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2530
fixes #2599
Add new problem report handler for connection protocol.
Update the ConnectionManagerError and ConnectionProblemReport to match the same base classes and structure as found in the DIDX protocol. There were issues where the ConnectionManagerErrors were actually failing during marshalling causing problem reports to not get sent. This is addressed by updating the classes and error_codes.
There is still a significant logic gap that I will raise in another issue - ProblemReport delivery requires an existing connection which is means we can't deliver a problem report to indicate the issue is the connection protocol... but leaving that discussion out of this PR.