Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point to official sd-jwt lib release #2573

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Oct 30, 2023

This PR adjusts the version of sd-jwt pulled to be the official release now published to PyPI: https://pypi.org/project/sd-jwt/

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm requested a review from swcurran October 30, 2023 19:07
@dbluhm
Copy link
Member Author

dbluhm commented Oct 30, 2023

@swcurran I think it would be good to get this in for 0.11.0; assuming tests pass, I think it's a pretty innocuous change and removes the only "unofficial"/git dependency we have, which should make integrating with ACA-Py from plugins or elsewhere simpler.

@swcurran
Copy link
Member

Before or after 0.11.0-rc0? Does it matter?

@dbluhm
Copy link
Member Author

dbluhm commented Oct 30, 2023

Either way works for me!

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should have merged before 0.11.0-rc0, as it failed to publish, likely because of this. :-(

@swcurran swcurran merged commit f7eff5d into hyperledger:main Oct 30, 2023
9 checks passed
@swcurran swcurran removed the 0.11.0 label Oct 30, 2023
@dbluhm dbluhm deleted the chore/sd-jwt-lib-official branch January 30, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants