Fixed:Routing behind a mediator #2535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codespree
changed the title
dbluhm
previously approved these changes
Oct 7, 2023
|
We'll probably want this change on 0.10.X, @swcurran |
|
Github Codespaces failed me and didn't include a DCO message on the commit I pushed... I'll fix that. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Well shoot. Sorry @codespree I got my git command syntax messed up and somehow managed to close this PR and now I can't correct it because closing the PR took away my ability to push to your branch. I will open another PR. Sorry for the mixup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, now routing works for agents behind a mediator:
#2531
Basically, since pydid expects routingKeys to be refs, this causes issues.
To fix this, the routingKeys are converted to refs if they aren't already.