Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax connections filter DID format #2451

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

chumbert
Copy link
Contributor

Relax the connection filter on my_did, their_did and their_public_did fields of the /connections endpoints.

These values were restricted to did:sov and are now open to the generic DID format.

@chumbert chumbert force-pushed the chore/relax-connection-filter branch from 51efc9f to 4aad45f Compare August 28, 2023 13:17
@dbluhm
Copy link
Member

dbluhm commented Aug 28, 2023

@swcurran I think we should get this one in for 0.10.0

@swcurran
Copy link
Member

Needs to be updated, please @chumbert

Signed-off-by: Clément Humbert <clement.humbert@sicpa.com>
@dbluhm dbluhm force-pushed the chore/relax-connection-filter branch from 4aad45f to c770505 Compare August 28, 2023 18:37
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit 450c666 into hyperledger:main Aug 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants