Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #385: Call EvaluateRuleEntry listeners when rules evaluated in FindMatchingRules #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corylation
Copy link

@corylation corylation commented Jul 13, 2023

Rules can be evaluated both in the engine's ExecuteWithContext()/Execute() function and inside of FindMatchingRules(), but listeners are only triggered in the Execute() call.

It'd be helpful if notifyEvaluateRuleEntry were added to FindMatchingRules() to trigger EvaluateRuleEntry listeners when FindMatchingRules() is called.

My motivation for this is to be able to get the rule names affected when FindMatchingRules() returns an error during processing of a rule like I'd do with a listener for Evaluate().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant