Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log feature of tracing #2326

Closed
seanmonstar opened this issue Nov 11, 2020 · 0 comments · Fixed by #2342
Closed

Remove log feature of tracing #2326

seanmonstar opened this issue Nov 11, 2020 · 0 comments · Fixed by #2342
Labels
A-dependencies Area: library dependencies. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
0.14

Comments

@seanmonstar
Copy link
Member

The log feature of tracing should not be enabled by default in hyper (or h2). Since people likely are depending on the log records, this is a breaking change, and should be done in 0.14 (with a note in the release notes).
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-dependencies Area: library dependencies. labels Nov 11, 2020
@seanmonstar seanmonstar added this to the 0.14 milestone Nov 11, 2020
mikeyhew added a commit to mikeyhew/hyper that referenced this issue Nov 24, 2020
@mikeyhew
remove log feature of tracing
3f36cd9 
fixes hyperium#2326
mikeyhew added a commit to mikeyhew/hyper that referenced this issue Nov 24, 2020
@mikeyhew
remove dependency on tracing's log feature
69b1b09 
fixes hyperium#2326
@mikeyhew mikeyhew mentioned this issue Nov 24, 2020
Merged
mikeyhew added a commit to mikeyhew/hyper that referenced this issue Nov 24, 2020
@mikeyhew
remove dependency on tracing's log feature
d9e78e9 
fixes hyperium#2326
seanmonstar pushed a commit that referenced this issue Nov 25, 2020
@mikeyhew
feat(lib): remove dependency on tracing's log feature (#2342)
db32e10 
Closes #2326

BREAKING CHANGE: hyper no longer emits `log` records automatically.
  If you need hyper to integrate with a `log` logger (as opposed to `tracing`),
  you can add `tracing = { version = "0.1", features = ["log"] }` to activate them.
@jxs jxs mentioned this issue Jun 5, 2021
Merged
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this issue Jul 26, 2021
@mikeyhew
feat(lib): remove dependency on tracing's log feature (hyperium#2342
33a5c65 
)

Closes hyperium#2326

BREAKING CHANGE: hyper no longer emits `log` records automatically.
  If you need hyper to integrate with a `log` logger (as opposed to `tracing`),
  you can add `tracing = { version = "0.1", features = ["log"] }` to activate them.
@johannescpk johannescpk mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: library dependencies. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

remove dependency on tracing's log feature mikeyhew/hyper
1 participant
@seanmonstar