fix: run dns resolution in the same tracing-span as the caller #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to trace the entire request, including DNS resolution. The use case for this is to be able to suppress specific requests from being traced in a situation where the request is used to transmit logs to a remote server. This would result in an infinite loop of logs being sent to the remote server. tokio-rs/tokio#6659 has more details.
|
Ping |
seanmonstar
reviewed
Jul 19, 2024
seanmonstar
reviewed
Aug 6, 2024
examples/client.rs
Outdated
| @@ -28,7 +29,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| .uri(url) | |||
| .body(Empty::<bytes::Bytes>::new())?; | |||
|
|
|||
| let resp = client.request(req).await?; | |||
| let span = info_span!("request", uri = %req.uri()); | |||
| let resp = client.request(req).instrument(span).await?; | |||
There was a problem hiding this comment.
Could we remove this too?
I agree it's useful when debugging, but I worry it distracts from the initial usage of someone just wanting to get the client working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to trace the entire request, including DNS
resolution.
The use case for this is to be able to suppress specific requests from
being traced in a situation where the request is used to transmit logs
to a remote server. This would result in an infinite loop of logs being
sent to the remote server. tokio-rs/tokio#6659
has more details.