util: Add a Collected body and combinator
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
commented
Oct 14, 2022
seanmonstar
reviewed
Oct 14, 2022
davidpdrsn
reviewed
Oct 14, 2022
LucioFranco
changed the title
Buffered body and combinatorCollected body and combinator
seanmonstar
reviewed
Oct 17, 2022
seanmonstar
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Looks great to me! Wouldn't mind @davidpdrsn looking once more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collectedbody that buffers all DATA frames and the trailers and provides ways to convert those DATA frames intoBytesandimpl Buf. These replace hyper'saggregate/to_bytesfree fns.BodyExt::colectcombinator to create a buffered body from anotherimpl Body.Related to hyperium/hyper#3010