Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itertools #929

Merged
merged 2 commits into from
Oct 1, 2015
Merged

Itertools #929

merged 2 commits into from
Oct 1, 2015

Conversation

gilch
Copy link
Member

@gilch gilch commented Sep 3, 2015

Closes #894.

Some names have been changed to protect the innocent. starmap->*map; combinations_with_replacement->multicombinations, which I think is the correct mathematical term; groupby->group-by and takewhile->take-while for consistency with drop-while.

Removed redundant filterfalse in favor of the shorter remove.

Removed redundant zipwith. Closes #927.

Made first and last more efficient.

Re-implemented accumulate so Hy can have it in Python2.

Some names have been changed.
Removed redundant zipwith.
Made `first` and `last` more efficient.
removed `filterfalse` in favor of the shorter `remove`
@Foxboron
Copy link
Member

Foxboron commented Sep 3, 2015

This looks solid, also noticed the setv's got replaced for the new def which is pretty nice. Love the sorting of the functions and so on. Great work

:shipit: 👍

@algernon
Copy link
Member

👍

I'm updating hydiomatic too, based on these changes.

@algernon algernon added this to the Grand Language Cleanup milestone Sep 22, 2015
algernon added a commit that referenced this pull request Oct 1, 2015
@algernon algernon merged commit 9569537 into hylang:master Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants