Clean up hy.contrib #1189
Merged
Clean up hy.contrib #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see why you'd put this in the standard library. I guess it could be useful for when you're maintaining a library and you want to change the name of a function or macro but keep the old name around for a while so people's code doesn't break immediately. But that's a pretty limited purpose.
tuturto
approved these changes
Dec 29, 2016
|
As a side note: what if we leave Botsbuildbots, but just remove it from the tests? Seems kind of silly that that's tested, but it's still a fun little easter egg. I personally kind of see it as akin to Python's |
Kodiologist
force-pushed
the
contrib-cleanup
branch
from
65effb0
to
16de4ef
Compare
|
@kirbyfan64 Ugh, fine. |
This is an Easter egg whose tests add a dependency (requests) and cause a test failure if you don't have an active Internet connection.
It's undocumented and of dubious value.
Now we can put it into contrib.multi instead of its own module.
It's not tested, and sure enough, a glance at the code suggests that `case` and `switch` will evaluate their first argument once for every clause, which is unlikely to be desirable. I say remove it, but if anybody wants to fix and test and re-add `case` (and change it to a square-bracket syntax like `cond`), be my guest.
This seems to be specific to Flask, a web framework.
Kodiologist
force-pushed
the
contrib-cleanup
branch
from
16de4ef
to
91b26d1
Compare
|
👍 happy to see the cleanup! |
|
(FWIW; I'm OK with removing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1162.