fixed viewing storage_map.column_value_mapping settings of a table

[agustinhydrolix]

Fixed error 'children' when displaying table settings

[hdxscott]

Your code seems fine, but the pre-existing code, such as the _get_dotted_key_from_dict function, is relying on KeyErrors for flow control. That's exactly what I was talking about with using .get instead of [].

What not to do:

try:
    value_we_want = dictionary["key"]
except KeyError:
    do_something_when_key_not_found_in_dict()

Much nicer:

value_we_want = dictionary.get("key", None)
if value_we_want is None:
    do_something_when_key_not_found()

The best:

value_we_want = dictionary.get("key", "default_value")

[agustinhydrolix]

In that particular case, when uses _get_dotted_key_from_dict the key is something like

nested_key = 'settings.storage_map.column_name'

That is a nested key and I cannot execute

dict.get(<nested_key>, default_value)