Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esphome build workflow #230

Merged
merged 7 commits into from
Sep 15, 2024
Merged

Use esphome build workflow #230

merged 7 commits into from
Sep 15, 2024

Conversation

jesserockz
Copy link
Collaborator

@jesserockz jesserockz commented Sep 15, 2024

What does this implement/fix? / Wat implementeert/repareert dit?

Proposed change / Voorgestelde verandering.

Types of changes / Soorten wijzigingen .

  • Bugfix (fixed change that fixes an issue) / Bugfix (vaste wijziging die een probleem verhelpt)
  • New feature (thanks!) / Nieuwe functie (bedankt!)
  • Breaking change (repair/feature that breaks existing functionality) / Breaking change (reparatie/functie waardoor bestaande functionaliteit kapot gaat)
  • Other / Ander
  • Website of github readme file update
  • Github workflows

Test Environment / Test Omgeving

  • Water meter / Watermeter
  • S0 counter / S0 teller
  • ESPHome version / ESPHome versie ````yaml # v202 ```
  • Home Assistant version / Home Assistant versie ````yaml # v202 ```
  • Website of github readme file update

Additional information / Aanvullende info

  • This PR fixes or closes the issue: fixes / Deze PR repareert of sluit het probleem: fixes #
  • This PR is related to an issue or discussion / Deze PR is gerelateerd aan een probleem of discussie:
  • Link to pull request for documentation / Link naar pull-aanvraag voor documentatie:

Supplying a configuration snippet / Voorbeeld invoer voor configuration.yaml:

# Example configuration.yaml

Checklist / Checklijst:

  • The code change has been tested and works locally / De codewijziging is getest en werkt lokaal.
  • The code change has not yet been tested / De codewijziging is nog niet getest.

If user-visible functionality or configuration variables are added/modified / Als door de gebruiker zichtbare functionaliteit of configuratievariabelen worden toegevoegd/gewijzigd :

  • Documentation added/updated in the readme file / Documentatie toegevoegd/bijgewerkt in de readme file.
  • Added/updated documentation for the web page / Documentatie toegevoegd/bijgewerkt voor de webpagina (s0tool.nl)[https://s0tool.nl].

Summary by CodeRabbit

  • New Features

    • Simplified firmware build process with a new workflow structure.
    • Updated URLs for firmware manifests across multiple devices to enhance accessibility.
  • Bug Fixes

    • Improved handling of firmware files and removal of intermediate version folders.
  • Documentation

    • Adjusted installation instructions to reflect new manifest file organization.

Copy link

coderabbitai bot commented Sep 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve updates to the GitHub Actions workflow for building firmware, replacing the matrix strategy with a reusable workflow. Environment variables have been removed, and release information handling has been streamlined. Additionally, several ESPHome component configuration files have had their firmware manifest URLs updated to reflect a new directory structure. The overall structure and organization of files have been improved for clarity and maintainability.

Changes

File(s) Change Summary
.github/workflows/build.yml Restructured build job to use a reusable workflow, removed environment variables, streamlined release info handling, and restricted deployment to release events.
esphome/components/s0tool-*-update.yml (multiple files) Updated firmware manifest URLs from *-manifest.json to */manifest.json, indicating a change in URL structure.
static/Installation.html Modified JavaScript to reference manifest files using a nested directory structure instead of a flat structure.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHubActions
    participant ESPHome
    participant Server

    User->>GitHubActions: Trigger build
    GitHubActions->>Server: Request firmware build
    Server-->>GitHubActions: Return build artifacts
    GitHubActions->>User: Notify build completion

    User->>ESPHome: Request firmware update
    ESPHome->>Server: Fetch manifest
    Server-->>ESPHome: Return updated manifest
    ESPHome->>User: Apply firmware update
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@huizebruin huizebruin marked this pull request as ready for review September 15, 2024 06:37
@huizebruin huizebruin merged commit c210038 into main Sep 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants