Configure Appveyor #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds both in Windows and in Linux.
|
Appveyor build: https://ci.appveyor.com/project/peagha/forca/builds/28644509 |
Done. At least I think it's done, it's my first time using Appveryor. How can we check if it's working or not? Should we merge this PR and see if it triggers a build of the master branch? |
Aruba doesn't work properly in Windows in the older versions. This PR adds Windows to the build matrix and updates Aruba to ensure the build is green.
peagha
force-pushed
the
configure-app-veyor-master
branch
from
931efab
to
b6e70c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot updated ffi, and I took the opportunity to configure a Windows build to ensure an updated Gem doesn't break the project in Windows.
I had to update Aruba because the older versions have many issues with Windows, e.g.: cucumber/aruba#387 (broken Appveyor build)
I also used a more recent Ruby version because some Aruba dependencies wouldn't work with older Rubies: https://ci.appveyor.com/project/peagha/forca/builds/28644278
We have the option not to configure Appveyor for the first edition of the book, because it requires a recent Ruby version. IMO having a green Windows build is better than having Ruby 1.9-2.2 support
@hugobarauna you'll need to add Appveyor to the project to enable the builds in this project