Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests with main revision and read token #33560

Merged
merged 8 commits into from
Sep 19, 2024
Merged

fix tests with main revision and read token #33560

merged 8 commits into from
Sep 19, 2024

Conversation

molbap
Copy link
Contributor

@molbap molbap commented Sep 18, 2024

What does this PR do?

Fixes slow tests in mamba2 not passing because read token was missing on the decorators.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@molbap
Copy link
Contributor Author

molbap commented Sep 18, 2024

slight overlap with #32599 where read_token is added, I also added back some tests that were skipped before but are now passing.
cc @amyeroberts for review :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

@molbap
Copy link
Contributor Author

molbap commented Sep 19, 2024

Only the multi-GPU test fails as reported in #33567, merging now.

@molbap molbap merged commit 4f0246e into main Sep 19, 2024
21 of 23 checks passed
@molbap molbap deleted the fix_tests_mamba2 branch September 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants