Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exllama v2 #1211

Merged
merged 11 commits into from
Nov 25, 2023
Merged

Exllama v2 #1211

merged 11 commits into from
Nov 25, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Oct 30, 2023

What does this PR do?

See #1165

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil mentioned this pull request Oct 30, 2023
5 tasks
@Narsil Narsil changed the title [WIP] Just showcasing some modification for exllama v2 Exllama v2 Nov 23, 2023
flozi00 and others added 10 commits November 25, 2023 11:50
It fails with illegal access on cuda when using sharding.
Took a long while to try and fix it:

All tensors are correct (same as v1).
Scratch size doesn't help
Error only occurs for sequence lengths > 50 (so during warmup most of
the time)

Couldn't figure out why this 50 particular number, nor change anything
to fix the behavior.
@Narsil Narsil merged commit ed2a3f6 into main Nov 25, 2023
5 of 6 checks passed
@Narsil Narsil deleted the tmp_exllamav2 branch November 25, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants