Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Riemannian Preconditioner #1807

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Integrating Riemannian Preconditioner #1807

wants to merge 9 commits into from

Commits on May 28, 2024

  1. initial draft

    @fangzhaozhang
    fangzhaozhang committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0852cfa View commit details
    Browse the repository at this point in the history

  2. add riemannian test

    @fangzhaozhang
    fangzhaozhang committed May 28, 2024
    Configuration menu
    Copy the full SHA
    550553a View commit details
    Browse the repository at this point in the history

  3. Update riemannian_test.py

    @fangzhaozhang
    fangzhaozhang committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dd32e8b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. cleanup loraplus code and run make file

    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3dc3f9e View commit details
    Browse the repository at this point in the history

  2. add proper reference to https://github.com/pilancilab/Riemannian_Prec… 

    …onditioned_LoRA
    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    dd7e85c View commit details
    Browse the repository at this point in the history

  3. modify tests and move prior test to examples

    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    735e386 View commit details
    Browse the repository at this point in the history

  4. make style

    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    445412c View commit details
    Browse the repository at this point in the history

  5. small fixes based on comment feedback

    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4526263 View commit details
    Browse the repository at this point in the history

  6. fix more suggestions in comment feedbacks

    @fangzhaozhang
    fangzhaozhang committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3017a5d View commit details
    Browse the repository at this point in the history