Improve error handling for invalid tokens during login

[WizKnight]

This PR enhances the error handling during the login process to provide users with more informative error messages when they attempt to log in with an invalid token. This addresses issue #2565 .

Key Changes:

Modified get_token_permission :

• The get_token_permission function now directly raises a ValueError if there is an HTTPError during the whoami call. This allows the original error message from the server to be included, giving users more context about the problem (e.g., "Invalid or expired token").
• The LocalTokenNotFoundError is no longer explicitly caught, as it's essentially an invalid token scenario, and the HTTPError from whoami will handle it.

Updated _login.py:

• The _login function continues to use get_token_permission to check token validity.
• If get_token_permission raises a ValueError, the error is sent to the user, providing them with the more informative server error message.

[WizKnight]

Hi @Wauplin :), changes have been implemented in this PR.
Please take a look and let me know if you have any further feedback or modifications!

Thanks!

[Wauplin]

Hi @WizKnight, actually @hanouticelina is working on a refacto of the login process to be able to set several tokens on a user's machine. This will affect this section of the code (see #2549 (comment)). I'm sorry if I have been unclear in #2565. The goal was not to change get_token_permission but to change how it is used in _login.py.

Thanks again for your work but I think for this one it's best to close the PR without merging. Sorry about that!

[WizKnight]

Hi @WizKnight, actually @hanouticelina is working on a refacto of the login process to be able to set several tokens on a user's machine. This will affect this section of the code (see #2549 (comment)). I'm sorry if I have been unclear in #2565. The goal was not to change get_token_permission but to change how it is used in _login.py.

Thanks again for your work but I think for this one it's best to close the PR without merging. Sorry about that!

Hi @Wauplin,
It's alright, thanks for clarifying this. Please go ahead and close this PR without merging.

And I'd appreciate, if you could assign me another task once this is done.

Thanks

[Wauplin]

Hi @WizKnight, thanks for your understanding. Regarding assigning another task, I don't have a good one in mind at the moment. We will have to set back a bit and think about the next steps. In any case, thanks for your support!

[WizKnight]

Hi @Wauplin, please do let me know if you need any assistance with upcoming tasks or any existing issues.
I'm happy to contribute🤗