Exclude Colab Enterprise from Google Colab token retrieval #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
julien-c
reviewed
Sep 10, 2024
Comment on lines
+306
to
+308
| def is_colab_enterprise() -> bool: | ||
| """Return `True` if code is executed in a Google Colab Enterprise environment.""" | ||
| return os.environ.get("VERTEX_PRODUCT") == "COLAB_ENTERPRISE" |
There was a problem hiding this comment.
maybe you could put this directly in is_google_colab? i.e. is_google_colab if on Colab but not on Colab Enterprise
There was a problem hiding this comment.
I'd rather keep it separated like this so that we have the correct information in the env dump (in case of a user reporting an issue)
Wauplin
reviewed
Sep 10, 2024
Comment on lines
+306
to
+308
| def is_colab_enterprise() -> bool: | ||
| """Return `True` if code is executed in a Google Colab Enterprise environment.""" | ||
| return os.environ.get("VERTEX_PRODUCT") == "COLAB_ENTERPRISE" |
There was a problem hiding this comment.
I'd rather keep it separated like this so that we have the correct information in the env dump (in case of a user reporting an issue)
Wauplin
approved these changes
Sep 10, 2024
…x-colab-enterprise-token-detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to a request made by the Google Colab team in a private discussion on slack.
This PR changes the way token retrieval works in Google Colab environments by excluding Google Colab Enterprise. Colab Enterprise uses a different secrets manager, so we're excluding this environment from the Google Colab token retrieval method.
changes made:
_get_token_from_google_colab()to detect and exclude Colab Enterprise