Add a default timeout for filelock

[edevil]

File lock operations did not have an associated timeout, which could present problems when trying to debug an issue since nothing would be logged if we could not acquire the lock and would wait forever.

[Wauplin]

Hi @edevil, thanks for raising the question. I'm not a fan of a 5min timeout since 1. it's already quite long for a user to debug 2. it's still too short when downloading huge files.
Instead of a timeout, what do you think of customizing the filelock so that:

1. it waits for 10s
2. if it raises a timeout, print a message (INFO log?) and wait indefinitely to acquire the lock (as done currently).

This way the new behavior will be similar to the current one, while still having a correct log message for the end user. What do you think?

[edevil]

Hey @Wauplin, addressed your comments. Thanks.

[Wauplin]

Thanks for making the quick changes @edevil! That's a good place where to put that indeed :) I've left some minor comments. Could you also run the linters? You need to install the dev dependencies (pip install -e ".[dev]") and run make style. To be sure the changes are correct, you can run make quality. Thanks!

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[edevil]

Could you also run the linters? You need to install the dev dependencies (pip install -e ".[dev]") and run make style. To be sure the changes are correct, you can run make quality. Thanks!

I did run those commands and it passed, maybe my editor changed something again on save. The failures don't seem related to this change, though. I've addressed your comments.

[Wauplin]

Thanks! PR looks good to me now :)

[Wauplin]

Failing tests are unrelated to your PR so I'm merging it now. Thanks @edevil!