Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated package_reference/environment_variables.md to Korean #2311

Merged

Conversation

jungnerd
Copy link
Contributor

@jungnerd jungnerd commented Jun 3, 2024

What does this PR do?

Translated the package_reference/environment_variables.md file of the documentation to Korean.
Besides, fixed a minor typo in en/package_reference/environment_variables.md.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cjfghk5697
Copy link
Contributor

LGTM!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jungnerd @cjfghk5697 ! ❤️

@Wauplin Wauplin marked this pull request as ready for review June 17, 2024 07:29
@Wauplin Wauplin merged commit 9d5e3d6 into huggingface:main Jun 17, 2024
2 checks passed
MoritzLaurer pushed a commit to MoritzLaurer/huggingface_hub that referenced this pull request Jul 3, 2024
…o Korean (huggingface#2311)

* docs: ko: package_reference/environment_variables.md

* feat: nmt draft

* feat: manual translate

* fix: manual edits

* fix: a minor typo

* fix: added manual translate

---------

Co-authored-by: Lucain <lucain@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants