Bump to 0.24 + remove deprecated code #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
May 27, 2024
|
Thanks for the reviews 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version to
0.24.0.dev0.Breaking changes:
ModelFilterandDatasetFilterare completely removed. You can now pass arguments directly tolist_modelsandlist_datasets. This removes one level of complexity for the same result.organizationandnamefromupdate_repo_visibility. Please use a properrepo_idinstead. This makes the method consistent with all other methods fromHfApi.These breaking changes have been announced with a regular deprecation cycle so hopefully it should be fine. In HF repos, I noticed a usage of
DatasetFilterin Setfit but that's all (PR to remove it: github.com/huggingface/setfit/pull/527).I also took the liberty to update code style in related tests, now using the pytest style. I did not change the tests logic.