Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] :: Add GitHub App Developer Guide #586

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

PauloMigAlmeida
Copy link
Contributor

@PauloMigAlmeida PauloMigAlmeida commented Oct 31, 2019

@bitwiseman

This PR adds the GitHub App Developer Guide section to the generated maven site of this library.

Screenshots to make it easier to preview how this is going to look like:

Home page: (Guide section on the left-hand side)
image

GitHub App Auth Flow
image

GitHub App Authentication via JWT token
image
image
image

Authenticating as an installation
image

Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my suggestions. Otherwise this is awesome work, thanks!

src/site/apt/githubappappinsttokenauth.apt Outdated Show resolved Hide resolved
src/site/apt/githubappappinsttokenauth.apt Outdated Show resolved Hide resolved
src/site/apt/githubappappinsttokenauth.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
src/site/apt/githubappflow.apt Outdated Show resolved Hide resolved
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
@PauloMigAlmeida
Copy link
Contributor Author

@bitwiseman changes made. Thanks for the proofreading 👍

@bitwiseman bitwiseman merged commit 0e01142 into hub4j:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants