Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] GHPerson: check if root is null #396

Merged
merged 1 commit into from
Jan 12, 2018
Merged

[fix] GHPerson: check if root is null #396

merged 1 commit into from
Jan 12, 2018

Conversation

Rechi
Copy link
Contributor

@Rechi Rechi commented Nov 9, 2017

This might fix the issue I reported at https://issues.jenkins-ci.org/browse/JENKINS-47848

@Rechi Rechi mentioned this pull request Nov 9, 2017
Closed
@Rechi
Copy link
Contributor Author

Rechi commented Nov 17, 2017

@kohsuke ping

oleg-nenashev
oleg-nenashev approved these changes Dec 12, 2017
View reviewed changes
Copy link
Collaborator

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nuclearsandwich nuclearsandwich mentioned this pull request Dec 20, 2017
Open
@dirk-thomas
Copy link

@kohsuke Friendly ping. The patch seems trivial and as reported by multiple users fixes a current problem. Please consider to merge and release this.

@kohsuke kohsuke merged commit 6effd4b into hub4j:master Jan 12, 2018
@dirk-thomas
Copy link

@kohsuke Thank you for merging this. What is the timeline for this patch to be released?

@kohsuke
Copy link
Collaborator

kohsuke commented Jan 12, 2018

I hope to make a pass on pending PRs and issues in this upcoming weekend and produce a new release. If I fail to deliver on that promise, please ping me again!

@Rechi Rechi deleted the fixGHPersonNullPointer branch January 12, 2018 19:26
eloycoto added a commit to eloycoto/ghprb that referenced this pull request Jan 19, 2018
@eloycoto
Updated github-api dependenci
ee72f38 
Updated to fix a NullPointerException

hub4j/github-api#396

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
@eloycoto eloycoto mentioned this pull request Jan 19, 2018
Closed
@dirk-thomas
Copy link

dirk-thomas commented Mar 23, 2018 •
edited
Loading

@kohsuke Shortly after your comment I notices that the master branch contains a release for version 1.92. But the plugin repository now only shows version 1.90 as the latest release. Am I missing something 😟

@dirk-thomas
Copy link

@kohsuke Friendly ping.

@dirk-thomas
Copy link

@kohsuke Can you please provide feedback on the question why there is no public release 1.92.

@kohsuke
Copy link
Collaborator

kohsuke commented Apr 14, 2018

@dirk-thomas I think you should ask that in https://github.com/jenkinsci/github-api-plugin as I'm no longer involved in releasing new versions of that plugin.

@dirk-thomas
Copy link

Reference for future readers: this has already been brought up in jenkinsci/github-api-plugin#19 three months ago but with no effect yet 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rechi @dirk-thomas @kohsuke @oleg-nenashev