#215 fix read() failure with private repos #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kohsuke Kawaguchi » github-api #389 SUCCESS |
|
Should the PR also modify |
|
There are many such request patterns in the class... |
|
Possibly. read() is 100% broken on private repos, though. getContent() works but it is deprecated. This does fix the issue and it seems unlikely to cause regression. I'll add a MockWebServer test if you support it. OkHttp is used so I suspect it is ok? |
|
@if6was9 |
reorder buildRequest()
|
Kohsuke Kawaguchi » github-api #390 SUCCESS |
…e#1-of ? extends GHHook[]>) is undefined
|
Kohsuke Kawaguchi » github-api #391 SUCCESS |
|
@if6was9 |
kohsuke
added a commit
that referenced
this pull request
Dec 1, 2015
#215 fix read() failure with private repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #215